fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Core/Services/PollService.swift

@@ -53,6 +53,8 @@ actor PollService {
 
     private var currentUserRecordID: String?
     private var pollSubscriptionIDs: Set<CKSubscription.ID> = []
+    /// Guard against TOCTOU races in vote submission
+    private var votesInProgress: Set<String> = []
 
     private init() {
         self.container = CloudKitContainerConfig.makeContainer()
@@ -213,6 +215,14 @@ actor PollService {
     // MARK: - Voting
 
     func submitVote(_ vote: PollVote) async throws -> PollVote {
+        // Guard against concurrent submissions for the same poll+voter
+        let voteKey = "\(vote.pollId.uuidString)_\(vote.voterId)"
+        guard !votesInProgress.contains(voteKey) else {
+            throw PollError.alreadyVoted
+        }
+        votesInProgress.insert(voteKey)
+        defer { votesInProgress.remove(voteKey) }
+
         // Check if user already voted
         let existingVote = try await fetchMyVote(forPollId: vote.pollId)
         if existingVote != nil {
@@ -233,7 +243,7 @@ actor PollService {
 
     func updateVote(_ vote: PollVote) async throws -> PollVote {
         let userId = try await getCurrentUserRecordID()
-        guard vote.odg == userId else {
+        guard vote.voterId == userId else {
             throw PollError.notVoteOwner
         }