fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Core/Services/LocationService.swift

@@ -7,6 +7,10 @@ import Foundation
 import CoreLocation
 import MapKit
 
+// SAFETY: MKPolyline is effectively immutable after creation and safe to pass across
+// isolation boundaries in practice. A proper fix would extract coordinates into a
+// Sendable value type, but MKPolyline is used widely (RouteInfo, map overlays) making
+// that refactor non-trivial. Tracked for future cleanup.
 extension MKPolyline: @retroactive @unchecked Sendable {}
 
 actor LocationService {
@@ -146,19 +150,30 @@ actor LocationService {
         origins: [CLLocationCoordinate2D],
         destinations: [CLLocationCoordinate2D]
     ) async throws -> [[RouteInfo?]] {
-        var matrix: [[RouteInfo?]] = []
+        let originCount = origins.count
+        let destCount = destinations.count
 
-        for origin in origins {
-            var row: [RouteInfo?] = []
-            for destination in destinations {
-                do {
-                    let route = try await calculateDrivingRoute(from: origin, to: destination)
-                    row.append(route)
-                } catch {
-                    row.append(nil)
+        // Pre-fill matrix with nils
+        var matrix: [[RouteInfo?]] = Array(repeating: Array(repeating: nil, count: destCount), count: originCount)
+
+        // Calculate all routes concurrently
+        try await withThrowingTaskGroup(of: (Int, Int, RouteInfo?).self) { group in
+            for (i, origin) in origins.enumerated() {
+                for (j, destination) in destinations.enumerated() {
+                    group.addTask {
+                        do {
+                            let route = try await self.calculateDrivingRoute(from: origin, to: destination)
+                            return (i, j, route)
+                        } catch {
+                            return (i, j, nil)
+                        }
+                    }
                 }
             }
-            matrix.append(row)
+
+            for try await (i, j, route) in group {
+                matrix[i][j] = route
+            }
         }
 
         return matrix