fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Core/Services/ItineraryItemService.swift

@@ -1,5 +1,6 @@
 import Foundation
 import CloudKit
+import os
 
 /// Service for persisting and syncing ItineraryItems to CloudKit
 actor ItineraryItemService {
@@ -73,16 +74,23 @@ actor ItineraryItemService {
                 retryCount[item.id] = nil
             }
         } catch {
-            // Keep failed updates queued and retry with backoff; never drop user edits.
+            // Keep failed updates queued and retry with backoff, but cap retries.
             var highestRetry = 0
             for item in updates.values {
                 let currentRetries = retryCount[item.id] ?? 0
-                let nextRetry = min(currentRetries + 1, maxRetries)
+                if currentRetries >= maxRetries {
+                    pendingUpdates.removeValue(forKey: item.id)
+                    retryCount.removeValue(forKey: item.id)
+                    os_log(.error, "Max retries reached for itinerary item %@", item.id.uuidString)
+                    continue
+                }
+                let nextRetry = currentRetries + 1
                 retryCount[item.id] = nextRetry
                 highestRetry = max(highestRetry, nextRetry)
                 pendingUpdates[item.id] = item
             }
 
+            guard !pendingUpdates.isEmpty else { return }
             let retryDelay = retryDelay(for: highestRetry)
             scheduleFlush(after: retryDelay)
         }