fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Core/Services/CloudKitService.swift

@@ -285,18 +285,16 @@ actor CloudKitService {
     }
 
     func checkAvailabilityWithError() async throws {
-        let status = await checkAccountStatus()
-        switch status {
-        case .available, .noAccount:
-            return
-        case .restricted:
-            throw CloudKitError.permissionDenied
-        case .couldNotDetermine:
-            throw CloudKitError.networkUnavailable
-        case .temporarilyUnavailable:
-            throw CloudKitError.networkUnavailable
-        @unknown default:
-            throw CloudKitError.networkUnavailable
+        guard await isAvailable() else {
+            let status = await checkAccountStatus()
+            switch status {
+            case .restricted:
+                throw CloudKitError.permissionDenied
+            case .temporarilyUnavailable:
+                throw CloudKitError.networkUnavailable
+            default:
+                throw CloudKitError.networkUnavailable
+            }
         }
     }
 
@@ -355,12 +353,12 @@ actor CloudKitService {
                 let homeId = homeRef.recordID.recordName
                 let awayId = awayRef.recordID.recordName
 
-                // Stadium ref is optional - use placeholder if not present
+                // Stadium ref is optional - use deterministic placeholder if not present
                 let stadiumId: String
                 if let stadiumRef = record[CKGame.stadiumRefKey] as? CKRecord.Reference {
                     stadiumId = stadiumRef.recordID.recordName
                 } else {
-                    stadiumId = "stadium_placeholder_\(UUID().uuidString)" // Placeholder - will be resolved via team lookup
+                    stadiumId = "placeholder_\(record.recordID.recordName)"
                 }
 
                 return ckGame.game(homeTeamId: homeId, awayTeamId: awayId, stadiumId: stadiumId)