fix: comprehensive codebase hardening — crashes, silent failures, performance, and security

Fixes ~95 issues from deep audit across 12 categories in 82 files:

- Crash prevention: double-resume in PhotoMetadataExtractor, force unwraps in
  DateRangePicker, array bounds checks in polls/achievements, ProGate hit-test
  bypass, Dictionary(uniqueKeysWithValues:) → uniquingKeysWith in 4 files
- Silent failure elimination: all 34 try? sites replaced with do/try/catch +
  logging (SavedTrip, TripDetailView, CanonicalSyncService, BootstrapService,
  CanonicalModels, CKModels, SportsTimeApp, and more)
- Performance: cached DateFormatters (7 files), O(1) team lookups via
  AppDataProvider, achievement definition dictionary, AnimatedBackground
  consolidated from 19 Tasks to 1, task cancellation in SharePreviewView
- Concurrency: UIKit drawing → MainActor.run, background fetch timeout guard,
  @MainActor on ThemeManager/AppearanceManager, SyncLogger read/write race fix
- Planning engine: game end time in travel feasibility, state-aware city
  normalization, exact city matching, DrivingConstraints parameter propagation
- IAP: unknown subscription states → expired, unverified transaction logging,
  entitlements updated before paywall dismiss, restore visible to all users
- Security: API key to Info.plist lookup, filename sanitization in PDF export,
  honest User-Agent, removed stale "Feels" analytics super properties
- Navigation: consolidated competing navigationDestination, boolean → value-based
- Testing: 8 sleep() → waitForExistence, duplicates extracted, Swift 6 compat
- Service bugs: infinite retry cap, duplicate achievement prevention, TOCTOU vote
  fix, PollVote.odg → voterId rename, deterministic placeholder IDs, parallel
  MKDirections, Sendable-safe POI struct

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Core/Services/AchievementEngine.swift

@@ -120,27 +120,35 @@ final class AchievementEngine {
         let visits = try fetchAllVisits()
         let visitedStadiumIds = Set(visits.map { $0.stadiumId })
 
-        let currentAchievements = try fetchEarnedAchievements()
-        let currentAchievementIds = Set(currentAchievements.map { $0.achievementTypeId })
+        let currentEarnedAchievements = try fetchEarnedAchievements()
+        let currentEarnedIds = Set(currentEarnedAchievements.map { $0.achievementTypeId })
+        let allAchievements = try fetchAllAchievements()
 
         var newlyEarned: [AchievementDefinition] = []
 
         for definition in AchievementRegistry.all {
-            // Skip already earned
-            guard !currentAchievementIds.contains(definition.id) else { continue }
+            // Skip already earned (active, non-revoked)
+            guard !currentEarnedIds.contains(definition.id) else { continue }
 
             let isEarned = checkRequirement(definition.requirement, visits: visits, visitedStadiumIds: visitedStadiumIds)
 
             if isEarned {
                 newlyEarned.append(definition)
 
-                let visitIds = getContributingVisitIds(for: definition.requirement, visits: visits)
-                let achievement = Achievement(
-                    achievementTypeId: definition.id,
-                    sport: definition.sport,
-                    visitIds: visitIds
-                )
-                modelContext.insert(achievement)
+                // Check if a revoked achievement already exists — restore it instead of creating a duplicate
+                if let revokedAchievement = allAchievements.first(where: {
+                    $0.achievementTypeId == definition.id && $0.revokedAt != nil
+                }) {
+                    revokedAchievement.restore()
+                } else {
+                    let visitIds = getContributingVisitIds(for: definition.requirement, visits: visits)
+                    let achievement = Achievement(
+                        achievementTypeId: definition.id,
+                        sport: definition.sport,
+                        visitIds: visitIds
+                    )
+                    modelContext.insert(achievement)
+                }
             }
         }
 
@@ -377,17 +385,10 @@ final class AchievementEngine {
     // MARK: - Stadium Lookups
 
     private func getStadiumIdsForDivision(_ divisionId: String) -> [String] {
-        // Query CanonicalTeam to find teams in this division
-        let descriptor = FetchDescriptor<CanonicalTeam>(
-            predicate: #Predicate { $0.divisionId == divisionId && $0.deprecatedAt == nil }
-        )
-
-        guard let canonicalTeams = try? modelContext.fetch(descriptor) else {
-            return []
-        }
-
-        // Get canonical stadium IDs for these teams
-        return canonicalTeams.map { $0.stadiumCanonicalId }
+        // Use AppDataProvider for canonical data reads
+        return dataProvider.teams
+            .filter { $0.divisionId == divisionId }
+            .map { $0.stadiumId }
     }
 
     private func getStadiumIdsForConference(_ conferenceId: String) -> [String] {
@@ -427,6 +428,11 @@ final class AchievementEngine {
         )
         return try modelContext.fetch(descriptor)
     }
+
+    private func fetchAllAchievements() throws -> [Achievement] {
+        let descriptor = FetchDescriptor<Achievement>()
+        return try modelContext.fetch(descriptor)
+    }
 }
 
 // MARK: - Achievement Progress