fix: improve text contrast for badges, category chips, and separators

- Change attraction category color from .yellow to orange variant for
  readable text in both light and dark mode (QuickAddItemSheet, POIDetailSheet)
- Fix "optional" badge to use textPrimary-based colors for strong contrast
- Bump paywall dashed separator from 0.4 to 0.6 opacity
- Fix SuggestedTripCard bullet separator from textMuted(0.5) to textSecondary

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Features/Trip/Views/AddItem/POIDetailSheet.swift

@@ -175,7 +175,7 @@ struct POIDetailSheet: View {
         case .coffee: return .brown
         case .hotel: return .blue
         case .parking: return .green
-        case .attraction: return .yellow
+        case .attraction: return Color.orange.opacity(0.85)
         case .entertainment: return .purple
         }
     }