fix: improve text contrast for badges, category chips, and separators

- Change attraction category color from .yellow to orange variant for
  readable text in both light and dark mode (QuickAddItemSheet, POIDetailSheet)
- Fix "optional" badge to use textPrimary-based colors for strong contrast
- Bump paywall dashed separator from 0.4 to 0.6 opacity
- Fix SuggestedTripCard bullet separator from textMuted(0.5) to textSecondary

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SportsTime/Features/Home/Views/SuggestedTripCard.swift

@@ -51,7 +51,7 @@ struct SuggestedTripCard: View {
                 }
 
                 Text("•")
-                    .foregroundStyle(Theme.textMuted(colorScheme).opacity(0.5))
+                    .foregroundStyle(Theme.textSecondary(colorScheme))
 
                 Label {
                     Text(suggestedTrip.trip.stops.count == 1 ? "1 city" : "\(suggestedTrip.trip.stops.count) cities")