Audit and fix 52 test correctness issues across 22 files
Systematic audit of 1,191 tests found tests written to pass rather than verify correctness. Key fixes: Infrastructure: - TestClock: fixed timezone from .current to America/New_York (deterministic) - TestFixtures: added 1.3x road routing factor to match production - ItineraryTestHelpers: real per-city coordinates instead of hardcoded (40,-80) Planning tests: - Added missing Scenario E factory dispatch tests - Tightened 12 loose assertions (>= 1 → == 8.0, > 0 → range checks) - Fixed 4 no-op tests that accepted both success and failure - Fixed wrong repeat-city invariant (was checking same-day, not different-day) - Fixed tautological assertion in missing-stadium edge case Services/Domain/Export tests: - Replaced 4 placeholder tests (#expect(true)) with real assertions - Fixed tautological assertions in POISearchServiceTests - Fixed Chicago coordinate in RegionMapSelectorTests (-89 → -87.6553) - Added sort order verification to ItineraryRowFlatteningTests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -149,6 +149,44 @@ struct ScenarioPlannerFactoryTests {
|
||||
#expect(planner is ScenarioBPlanner, "B should take priority over C")
|
||||
}
|
||||
|
||||
@Test("planner: teamFirst with 2+ teams returns ScenarioEPlanner")
|
||||
func planner_teamFirst_returnsScenarioE() {
|
||||
let prefs = TripPreferences(
|
||||
planningMode: .teamFirst,
|
||||
sports: [.mlb],
|
||||
startDate: TestClock.now,
|
||||
endDate: TestClock.now.addingTimeInterval(86400 * 7),
|
||||
leisureLevel: .moderate,
|
||||
lodgingType: .hotel,
|
||||
numberOfDrivers: 1,
|
||||
selectedTeamIds: ["team-1", "team-2"]
|
||||
)
|
||||
|
||||
let request = makeRequest(preferences: prefs)
|
||||
let planner = ScenarioPlannerFactory.planner(for: request)
|
||||
|
||||
#expect(planner is ScenarioEPlanner)
|
||||
}
|
||||
|
||||
@Test("classify: teamFirst with 2+ teams returns scenarioE")
|
||||
func classify_teamFirst_returnsScenarioE() {
|
||||
let prefs = TripPreferences(
|
||||
planningMode: .teamFirst,
|
||||
sports: [.mlb],
|
||||
startDate: TestClock.now,
|
||||
endDate: TestClock.now.addingTimeInterval(86400 * 7),
|
||||
leisureLevel: .moderate,
|
||||
lodgingType: .hotel,
|
||||
numberOfDrivers: 1,
|
||||
selectedTeamIds: ["team-1", "team-2"]
|
||||
)
|
||||
|
||||
let request = makeRequest(preferences: prefs)
|
||||
let scenario = ScenarioPlannerFactory.classify(request)
|
||||
|
||||
#expect(scenario == .scenarioE)
|
||||
}
|
||||
|
||||
// MARK: - Specification Tests: classify()
|
||||
|
||||
@Test("classify: followTeamId returns scenarioD")
|
||||
|
||||
Reference in New Issue
Block a user