Audit and fix 52 test correctness issues across 22 files
Systematic audit of 1,191 tests found tests written to pass rather than verify correctness. Key fixes: Infrastructure: - TestClock: fixed timezone from .current to America/New_York (deterministic) - TestFixtures: added 1.3x road routing factor to match production - ItineraryTestHelpers: real per-city coordinates instead of hardcoded (40,-80) Planning tests: - Added missing Scenario E factory dispatch tests - Tightened 12 loose assertions (>= 1 → == 8.0, > 0 → range checks) - Fixed 4 no-op tests that accepted both success and failure - Fixed wrong repeat-city invariant (was checking same-day, not different-day) - Fixed tautological assertion in missing-stadium edge case Services/Domain/Export tests: - Replaced 4 placeholder tests (#expect(true)) with real assertions - Fixed tautological assertions in POISearchServiceTests - Fixed Chicago coordinate in RegionMapSelectorTests (-89 → -87.6553) - Added sort order verification to ItineraryRowFlatteningTests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -8,7 +8,7 @@
|
||||
import Foundation
|
||||
|
||||
enum TestClock {
|
||||
static let timeZone = TimeZone.current
|
||||
static let timeZone = TimeZone(identifier: "America/New_York")!
|
||||
static let locale = Locale(identifier: "en_US_POSIX")
|
||||
|
||||
static let calendar: Calendar = {
|
||||
|
||||
@@ -292,7 +292,7 @@ enum TestFixtures {
|
||||
let toCoord = coordinates[to] ?? CLLocationCoordinate2D(latitude: 42.0, longitude: -71.0)
|
||||
|
||||
// Calculate approximate distance (haversine)
|
||||
let distance = haversineDistance(from: fromCoord, to: toCoord)
|
||||
let distance = haversineDistance(from: fromCoord, to: toCoord) * 1.3
|
||||
// Estimate driving time at 60 mph average
|
||||
let duration = distance / 60.0 * 3600.0
|
||||
|
||||
|
||||
Reference in New Issue
Block a user