Audit and fix 52 test correctness issues across 22 files

Systematic audit of 1,191 tests found tests written to pass rather than
verify correctness. Key fixes:

Infrastructure:
- TestClock: fixed timezone from .current to America/New_York (deterministic)
- TestFixtures: added 1.3x road routing factor to match production
- ItineraryTestHelpers: real per-city coordinates instead of hardcoded (40,-80)

Planning tests:
- Added missing Scenario E factory dispatch tests
- Tightened 12 loose assertions (>= 1 → == 8.0, > 0 → range checks)
- Fixed 4 no-op tests that accepted both success and failure
- Fixed wrong repeat-city invariant (was checking same-day, not different-day)
- Fixed tautological assertion in missing-stadium edge case

Services/Domain/Export tests:
- Replaced 4 placeholder tests (#expect(true)) with real assertions
- Fixed tautological assertions in POISearchServiceTests
- Fixed Chicago coordinate in RegionMapSelectorTests (-89 → -87.6553)
- Added sort order verification to ItineraryRowFlatteningTests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

SportsTimeTests/Features/Trip/ItineraryRowFlatteningTests.swift

@@ -105,6 +105,18 @@ final class ItineraryRowFlatteningTests: XCTestCase {
         // Then: Items should appear in sortOrder: First (1.0), Second (2.0), Third (3.0)
         let rowCount = controller.tableView(controller.tableView, numberOfRowsInSection: 0)
         XCTAssertEqual(rowCount, 4, "Expected 4 rows: header + 3 items")
+
+        // Verify items are actually sorted by sortOrder (ascending)
+        let rows = controller.flatItems
+        let itemRows = rows.filter { $0.isReorderable }
+        XCTAssertEqual(itemRows.count, 3, "Should have 3 reorderable items")
+
+        // Extract sortOrder values from the custom items
+        let sortOrders: [Double] = itemRows.compactMap {
+            if case .customItem(let item) = $0 { return item.sortOrder }
+            return nil
+        }
+        XCTAssertEqual(sortOrders, [1.0, 2.0, 3.0], "Items should be in ascending sortOrder: First, Second, Third")
     }
 
     // MARK: - Day Number Calculation Tests