fix: codebase audit fixes — safety, accessibility, and production hygiene
Address 16 issues from external audit: - Move StoreKit transaction listener ownership to StoreManager singleton with proper deinit - Remove noisy VoiceOver announcements, add missing accessibility on StatPill and BootstrapLoadingView - Replace String @retroactive Identifiable with IdentifiableShareCode wrapper - Add crash guard in AchievementEngine getContributingVisitIds + cache stadium lookups - Pre-compute GamesHistoryViewModel filtered properties to avoid redundant SwiftUI recomputation - Remove force-unwraps in ProgressMapView with safe guard-let fallback - Add diff-based update gating in ItineraryTableViewWrapper to prevent unnecessary reloads - Replace deprecated UIScreen.main with UIWindowScene lookup - Add deinit task cancellation in ScheduleViewModel and SuggestedTripsGenerator - Wrap ~234 unguarded print() calls across 27 files in #if DEBUG Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
@@ -197,12 +197,14 @@ struct TripDetailView: View {
|
||||
private func handleItineraryItemsChange(_ newItems: [ItineraryItem]) {
|
||||
draggedItem = nil
|
||||
dropTargetId = nil
|
||||
#if DEBUG
|
||||
print("🗺️ [MapUpdate] itineraryItems changed, count: \(newItems.count)")
|
||||
for item in newItems {
|
||||
if item.isCustom, let info = item.customInfo, info.isMappable {
|
||||
print("🗺️ [MapUpdate] Mappable: \(info.title) on day \(item.day), sortOrder: \(item.sortOrder)")
|
||||
}
|
||||
}
|
||||
#endif
|
||||
mapUpdateTask?.cancel()
|
||||
mapUpdateTask = Task {
|
||||
updateMapRegion()
|
||||
@@ -851,7 +853,9 @@ struct TripDetailView: View {
|
||||
updated.modifiedAt = Date()
|
||||
|
||||
let title = item.customInfo?.title ?? "item"
|
||||
#if DEBUG
|
||||
print("📍 [Move] Moving \(title) to day \(day), sortOrder: \(sortOrder)")
|
||||
#endif
|
||||
|
||||
// Update local state
|
||||
if let idx = itineraryItems.firstIndex(where: { $0.id == item.id }) {
|
||||
@@ -863,7 +867,9 @@ struct TripDetailView: View {
|
||||
|
||||
// Sync to CloudKit (debounced)
|
||||
await ItineraryItemService.shared.updateItem(updated)
|
||||
#if DEBUG
|
||||
print("✅ [Move] Synced \(title) with day: \(day), sortOrder: \(sortOrder)")
|
||||
#endif
|
||||
}
|
||||
|
||||
/// Recompute cached itinerary sections from current state.
|
||||
@@ -1389,7 +1395,9 @@ struct TripDetailView: View {
|
||||
// MARK: - Itinerary Items (Local-first persistence with CloudKit sync)
|
||||
|
||||
private func loadItineraryItems() async {
|
||||
#if DEBUG
|
||||
print("🔍 [ItineraryItems] Loading items for trip: \(trip.id)")
|
||||
#endif
|
||||
|
||||
// 1. Load from local SwiftData first (instant, works offline)
|
||||
let tripId = trip.id
|
||||
@@ -1398,7 +1406,9 @@ struct TripDetailView: View {
|
||||
)
|
||||
let localItems = (try? modelContext.fetch(descriptor))?.compactMap(\.toItem) ?? []
|
||||
if !localItems.isEmpty {
|
||||
#if DEBUG
|
||||
print("✅ [ItineraryItems] Loaded \(localItems.count) items from local cache")
|
||||
#endif
|
||||
itineraryItems = localItems
|
||||
extractTravelOverrides(from: localItems)
|
||||
}
|
||||
@@ -1406,7 +1416,9 @@ struct TripDetailView: View {
|
||||
// 2. Try CloudKit for latest data (background sync)
|
||||
do {
|
||||
let cloudItems = try await ItineraryItemService.shared.fetchItems(forTripId: trip.id)
|
||||
#if DEBUG
|
||||
print("✅ [ItineraryItems] Loaded \(cloudItems.count) items from CloudKit")
|
||||
#endif
|
||||
|
||||
// Merge: use CloudKit as source of truth when available
|
||||
if !cloudItems.isEmpty || localItems.isEmpty {
|
||||
@@ -1415,7 +1427,9 @@ struct TripDetailView: View {
|
||||
syncLocalCache(with: cloudItems)
|
||||
}
|
||||
} catch {
|
||||
#if DEBUG
|
||||
print("⚠️ [ItineraryItems] CloudKit fetch failed (using local cache): \(error)")
|
||||
#endif
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1429,7 +1443,9 @@ struct TripDetailView: View {
|
||||
segIdx < trip.travelSegments.count {
|
||||
let segment = trip.travelSegments[segIdx]
|
||||
if !travelInfo.matches(segment: segment) {
|
||||
#if DEBUG
|
||||
print("⚠️ [TravelOverrides] Mismatched travel cities for segment \(segIdx); using canonical segment cities")
|
||||
#endif
|
||||
}
|
||||
let travelId = stableTravelAnchorId(segment, at: segIdx)
|
||||
overrides[travelId] = TravelOverride(day: item.day, sortOrder: item.sortOrder)
|
||||
@@ -1441,7 +1457,9 @@ struct TripDetailView: View {
|
||||
}
|
||||
|
||||
guard matches.count == 1, let match = matches.first else {
|
||||
#if DEBUG
|
||||
print("⚠️ [TravelOverrides] Ignoring ambiguous legacy travel override \(travelInfo.fromCity)->\(travelInfo.toCity)")
|
||||
#endif
|
||||
continue
|
||||
}
|
||||
|
||||
@@ -1452,7 +1470,9 @@ struct TripDetailView: View {
|
||||
}
|
||||
|
||||
travelOverrides = overrides
|
||||
#if DEBUG
|
||||
print("✅ [TravelOverrides] Extracted \(overrides.count) travel overrides (day + sortOrder)")
|
||||
#endif
|
||||
}
|
||||
|
||||
private func syncLocalCache(with items: [ItineraryItem]) {
|
||||
@@ -1473,7 +1493,9 @@ struct TripDetailView: View {
|
||||
private func saveItineraryItem(_ item: ItineraryItem) async {
|
||||
let isUpdate = itineraryItems.contains(where: { $0.id == item.id })
|
||||
let title = item.customInfo?.title ?? "item"
|
||||
#if DEBUG
|
||||
print("💾 [ItineraryItems] Saving item: '\(title)' (isUpdate: \(isUpdate))")
|
||||
#endif
|
||||
|
||||
// Update in-memory state immediately
|
||||
if isUpdate {
|
||||
@@ -1491,14 +1513,20 @@ struct TripDetailView: View {
|
||||
do {
|
||||
if isUpdate {
|
||||
await ItineraryItemService.shared.updateItem(item)
|
||||
#if DEBUG
|
||||
print("✅ [ItineraryItems] Updated in CloudKit: \(title)")
|
||||
#endif
|
||||
} else {
|
||||
_ = try await ItineraryItemService.shared.createItem(item)
|
||||
#if DEBUG
|
||||
print("✅ [ItineraryItems] Created in CloudKit: \(title)")
|
||||
#endif
|
||||
markLocalItemSynced(item.id)
|
||||
}
|
||||
} catch {
|
||||
#if DEBUG
|
||||
print("⚠️ [ItineraryItems] CloudKit save failed (saved locally): \(error)")
|
||||
#endif
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1535,7 +1563,9 @@ struct TripDetailView: View {
|
||||
|
||||
private func deleteItineraryItem(_ item: ItineraryItem) async {
|
||||
let title = item.customInfo?.title ?? "item"
|
||||
#if DEBUG
|
||||
print("🗑️ [ItineraryItems] Deleting item: '\(title)'")
|
||||
#endif
|
||||
|
||||
// Remove from in-memory state
|
||||
itineraryItems.removeAll { $0.id == item.id }
|
||||
@@ -1553,9 +1583,13 @@ struct TripDetailView: View {
|
||||
// Delete from CloudKit
|
||||
do {
|
||||
try await ItineraryItemService.shared.deleteItem(item.id)
|
||||
#if DEBUG
|
||||
print("✅ [ItineraryItems] Deleted from CloudKit")
|
||||
#endif
|
||||
} catch {
|
||||
#if DEBUG
|
||||
print("⚠️ [ItineraryItems] CloudKit delete failed (removed locally): \(error)")
|
||||
#endif
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1632,12 +1666,16 @@ struct TripDetailView: View {
|
||||
}
|
||||
|
||||
private func saveTravelDayOverride(travelAnchorId: String, displayDay: Int, sortOrder: Double) async {
|
||||
#if DEBUG
|
||||
print("💾 [TravelOverrides] Saving override: \(travelAnchorId) -> day \(displayDay), sortOrder \(sortOrder)")
|
||||
#endif
|
||||
|
||||
guard let segmentIndex = Self.parseSegmentIndex(from: travelAnchorId),
|
||||
segmentIndex >= 0,
|
||||
segmentIndex < trip.travelSegments.count else {
|
||||
#if DEBUG
|
||||
print("❌ [TravelOverrides] Invalid travel segment index in ID: \(travelAnchorId)")
|
||||
#endif
|
||||
return
|
||||
}
|
||||
|
||||
@@ -1676,14 +1714,18 @@ struct TripDetailView: View {
|
||||
_ = try await ItineraryItemService.shared.createItem(item)
|
||||
markLocalItemSynced(item.id)
|
||||
} catch {
|
||||
#if DEBUG
|
||||
print("❌ [TravelOverrides] CloudKit save failed: \(error)")
|
||||
#endif
|
||||
return
|
||||
}
|
||||
}
|
||||
#if DEBUG
|
||||
if canonicalTravelId != travelAnchorId {
|
||||
print("ℹ️ [TravelOverrides] Canonicalized travel ID to \(canonicalTravelId)")
|
||||
}
|
||||
print("✅ [TravelOverrides] Saved to CloudKit")
|
||||
#endif
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user