admin/Sportstime
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: TripDetailView loads games on demand, improve poll UI

Browse Source 
- Refactor TripDetailView to fetch games from AppDataProvider when not
  provided, adding loading state indicator for better UX
- Update all callers (25+ HomeContent variants, TripOptionsView, HomeView)
  to use simpler TripDetailView(trip:) initializer
- Fix PollDetailView sheet issue by using sheet(item:) instead of
  sheet(isPresented:) to prevent blank screen on first tap
- Improve PollDetailView UI with Theme styling, icons, and better
  visual hierarchy for share code, voting status, and results sections

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-01-14 11:31:05 -06:00
parent b5aea31b1a
commit 2ad458bffd
28 changed files with 314 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
SportsTime/Features/Home/Views/Variants/Airbnb/HomeContent_Airbnb.swift
View File

@@ -166,7 +166,7 @@ struct HomeContent_Airbnb: View {
ForEach(savedTrips.prefix(4)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
tripCard(trip)
}

2
SportsTime/Features/Home/Views/Variants/AppleMaps/HomeContent_AppleMaps.swift
View File

@@ -123,7 +123,7 @@ struct HomeContent_AppleMaps: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
recentRow(trip, isLast: index == min(2, savedTrips.count - 1))
}

2
SportsTime/Features/Home/Views/Variants/ArtDeco/HomeContent_ArtDeco.swift
View File

@@ -424,7 +424,7 @@ struct HomeContent_ArtDeco: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack {
decoDiamond

2
SportsTime/Features/Home/Views/Variants/Brutalist/HomeContent_Brutalist.swift
View File

@@ -224,7 +224,7 @@ struct HomeContent_Brutalist: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack {
Text(trip.name.uppercased())

2
SportsTime/Features/Home/Views/Variants/CarrotWeather/HomeContent_CarrotWeather.swift
View File

@@ -215,7 +215,7 @@ struct HomeContent_CarrotWeather: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
tripRow(trip)
}

2
SportsTime/Features/Home/Views/Variants/Classic/HomeContent_Classic.swift
View File

@@ -207,7 +207,7 @@ struct HomeContent_Classic: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
classicTripCard(savedTrip: savedTrip, trip: trip)
}

2
SportsTime/Features/Home/Views/Variants/DarkIndustrial/HomeContent_DarkIndustrial.swift
View File

@@ -376,7 +376,7 @@ struct HomeContent_DarkIndustrial: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack {
Rectangle()

2
SportsTime/Features/Home/Views/Variants/Fantastical/HomeContent_Fantastical.swift
View File

@@ -183,7 +183,7 @@ struct HomeContent_Fantastical: View {
ForEach(savedTrips.prefix(4)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
eventRow(trip)
}

2
SportsTime/Features/Home/Views/Variants/Flighty/HomeContent_Flighty.swift
View File

@@ -193,7 +193,7 @@ struct HomeContent_Flighty: View {
ForEach(savedTrips.prefix(2)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
tripCard(trip)
}

2
SportsTime/Features/Home/Views/Variants/Glassmorphism/HomeContent_Glassmorphism.swift
View File

@@ -284,7 +284,7 @@ struct HomeContent_Glassmorphism: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack(spacing: 16) {
// Glow orb

2
SportsTime/Features/Home/Views/Variants/LuxuryEditorial/HomeContent_LuxuryEditorial.swift
View File

@@ -283,7 +283,7 @@ struct HomeContent_LuxuryEditorial: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack(alignment: .top, spacing: 16) {
// Number

2
SportsTime/Features/Home/Views/Variants/MaximalistChaos/HomeContent_MaximalistChaos.swift
View File

@@ -392,7 +392,7 @@ struct HomeContent_MaximalistChaos: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
let colors = [skyBlue, hotOrange, electricPurple]
let accentColor = colors[index % colors.count]

2
SportsTime/Features/Home/Views/Variants/NeoBrutalist/HomeContent_NeoBrutalist.swift
View File

@@ -290,7 +290,7 @@ struct HomeContent_NeoBrutalist: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack {
Rectangle()

2
SportsTime/Features/Home/Views/Variants/NikeRunClub/HomeContent_NikeRunClub.swift
View File

@@ -169,7 +169,7 @@ struct HomeContent_NikeRunClub: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
activityRow(trip, index: index)
}

2
SportsTime/Features/Home/Views/Variants/Organic/HomeContent_Organic.swift
View File

@@ -248,7 +248,7 @@ struct HomeContent_Organic: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack(spacing: 14) {
// Organic dot cluster

2
SportsTime/Features/Home/Views/Variants/Playful/HomeContent_Playful.swift
View File

@@ -304,7 +304,7 @@ struct HomeContent_Playful: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
let colors = [candyYellow, candyGreen, candyBlue]
let accentColor = colors[index % colors.count]

2
SportsTime/Features/Home/Views/Variants/RetroFuturism/HomeContent_RetroFuturism.swift
View File

@@ -303,7 +303,7 @@ struct HomeContent_RetroFuturism: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
HStack {
Text(trip.name)

2
SportsTime/Features/Home/Views/Variants/SeatGeek/HomeContent_SeatGeek.swift
View File

@@ -162,7 +162,7 @@ struct HomeContent_SeatGeek: View {
ForEach(savedTrips.prefix(4)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
yourTripCard(trip)
}

2
SportsTime/Features/Home/Views/Variants/SoftPastel/HomeContent_SoftPastel.swift
View File

@@ -321,7 +321,7 @@ struct HomeContent_SoftPastel: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
let colors = [pastelPeach, pastelMint, pastelLavender]
let accentColor = colors[index % colors.count]

2
SportsTime/Features/Home/Views/Variants/Spotify/HomeContent_Spotify.swift
View File

@@ -101,7 +101,7 @@ struct HomeContent_Spotify: View {
ForEach(savedTrips.prefix(5)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
tripCoverCard(trip)
}

2
SportsTime/Features/Home/Views/Variants/Strava/HomeContent_Strava.swift
View File

@@ -210,7 +210,7 @@ struct HomeContent_Strava: View {
ForEach(savedTrips.prefix(3)) { savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
activityCard(trip)
}

2
SportsTime/Features/Home/Views/Variants/SwissModernist/HomeContent_SwissModernist.swift
View File

@@ -304,7 +304,7 @@ struct HomeContent_SwissModernist: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
VStack(spacing: 0) {
HStack(spacing: 24) {

2
SportsTime/Features/Home/Views/Variants/Things3/HomeContent_Things3.swift
View File

@@ -162,7 +162,7 @@ struct HomeContent_Things3: View {
ForEach(Array(savedTrips.prefix(3).enumerated()), id: \.element.id) { index, savedTrip in
if let trip = savedTrip.trip {
NavigationLink {
TripDetailView(trip: trip, games: savedTrip.games)
TripDetailView(trip: trip)
} label: {
tripRow(trip)
}