wip

Scripts/sportstime_parser/models/team.py

@@ -54,6 +54,20 @@ class Team:
             "stadium_id": self.stadium_id,
         }
 
+    def _make_qualified_id(self, name: Optional[str]) -> Optional[str]:
+        """Convert a conference/division name to a qualified ID.
+
+        Examples:
+            "Eastern" → "nba_eastern"
+            "AL West" → "mlb_al_west"
+            "Southeast" → "nba_southeast"
+        """
+        if not name:
+            return None
+        # Lowercase, replace spaces with underscores
+        normalized = name.lower().replace(" ", "_")
+        return f"{self.sport.lower()}_{normalized}"
+
     def to_canonical_dict(self) -> dict:
         """Convert to canonical dictionary format matching iOS app schema.
 
@@ -67,8 +81,8 @@ class Team:
             "sport": self.sport.upper(),  # iOS Sport enum expects uppercase (e.g., "NFL")
             "city": self.city,
             "stadium_canonical_id": self.stadium_id or "",
-            "conference_id": self.conference,
-            "division_id": self.division,
+            "conference_id": self._make_qualified_id(self.conference),
+            "division_id": self._make_qualified_id(self.division),
             "primary_color": self.primary_color,
             "secondary_color": self.secondary_color,
         }
@@ -91,9 +105,38 @@ class Team:
             stadium_id=data.get("stadium_id"),
         )
 
+    @staticmethod
+    def _extract_name_from_qualified_id(qualified_id: Optional[str], sport: str) -> Optional[str]:
+        """Extract the name portion from a qualified ID.
+
+        Examples:
+            "nba_eastern" → "Eastern"
+            "mlb_al_west" → "AL West"
+            "nba_southeast" → "Southeast"
+        """
+        if not qualified_id:
+            return None
+        # Remove sport prefix (e.g., "nba_" or "mlb_")
+        prefix = f"{sport.lower()}_"
+        if qualified_id.startswith(prefix):
+            name = qualified_id[len(prefix):]
+        else:
+            name = qualified_id
+        # Convert underscores to spaces and title case
+        # Special handling for league abbreviations (AL, NL, etc.)
+        parts = name.split("_")
+        result_parts = []
+        for part in parts:
+            if part.upper() in ("AL", "NL", "AFC", "NFC"):
+                result_parts.append(part.upper())
+            else:
+                result_parts.append(part.capitalize())
+        return " ".join(result_parts)
+
     @classmethod
     def from_canonical_dict(cls, data: dict) -> "Team":
         """Create a Team from a canonical dictionary (iOS app format)."""
+        sport = data["sport"].lower()
         return cls(
             id=data["canonical_id"],
             sport=data["sport"],
@@ -101,8 +144,8 @@ class Team:
             name=data["name"],
             full_name=f"{data['city']} {data['name']}",  # Reconstruct full_name
             abbreviation=data["abbreviation"],
-            conference=data.get("conference_id"),
-            division=data.get("division_id"),
+            conference=cls._extract_name_from_qualified_id(data.get("conference_id"), sport),
+            division=cls._extract_name_from_qualified_id(data.get("division_id"), sport),
             primary_color=data.get("primary_color"),
             secondary_color=data.get("secondary_color"),
             stadium_id=data.get("stadium_canonical_id"),