d97db4910e
Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method
Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView
Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules
Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
63 lines
2.3 KiB
Swift
63 lines
2.3 KiB
Swift
//
|
|
// TabBarScreen.swift
|
|
// Tests iOS
|
|
//
|
|
// Screen object for the main tab bar navigation.
|
|
//
|
|
|
|
import XCTest
|
|
|
|
struct TabBarScreen {
|
|
let app: XCUIApplication
|
|
|
|
private let defaultTimeout: TimeInterval = 2
|
|
private let navigationTimeout: TimeInterval = 5
|
|
|
|
// MARK: - Actions
|
|
|
|
@discardableResult
|
|
func tapDay(file: StaticString = #filePath, line: UInt = #line) -> DayScreen {
|
|
app.tapTab(identifier: UITestID.Tab.day, labels: ["Day", "Main"], timeout: navigationTimeout, file: file, line: line)
|
|
return DayScreen(app: app)
|
|
}
|
|
|
|
@discardableResult
|
|
func tapMonth(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
|
|
app.tapTab(identifier: UITestID.Tab.month, labels: ["Month"], timeout: navigationTimeout, file: file, line: line)
|
|
return self
|
|
}
|
|
|
|
@discardableResult
|
|
func tapYear(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
|
|
app.tapTab(identifier: UITestID.Tab.year, labels: ["Year", "Filter"], timeout: navigationTimeout, file: file, line: line)
|
|
return self
|
|
}
|
|
|
|
@discardableResult
|
|
func tapInsights(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
|
|
app.tapTab(identifier: UITestID.Tab.insights, labels: ["Insights"], timeout: navigationTimeout, file: file, line: line)
|
|
return self
|
|
}
|
|
|
|
@discardableResult
|
|
func tapSettings(file: StaticString = #filePath, line: UInt = #line) -> SettingsScreen {
|
|
app.tapTab(identifier: UITestID.Tab.settings, labels: ["Settings"], timeout: navigationTimeout, file: file, line: line)
|
|
return SettingsScreen(app: app)
|
|
}
|
|
|
|
// MARK: - Assertions
|
|
|
|
@discardableResult
|
|
func assertVisible(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
|
|
app.tabBars.firstMatch
|
|
.waitForExistenceOrFail(timeout: navigationTimeout, message: "Tab bar should be visible", file: file, line: line)
|
|
return self
|
|
}
|
|
|
|
func assertDayTabSelected(file: StaticString = #filePath, line: UInt = #line) {
|
|
let dayTab = app.tabBars.buttons[UITestID.Tab.day]
|
|
dayTab.waitForExistenceOrFail(timeout: defaultTimeout, message: "Day tab should exist", file: file, line: line)
|
|
XCTAssertTrue(dayTab.isSelected, "Day tab should be selected", file: file, line: line)
|
|
}
|
|
}
|