admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing accessibility identifiers to all interactive UI elements

Browse Source 
Audit found ~50+ interactive elements (buttons, toggles, pickers, alerts,
links) missing accessibility identifiers across 13 view files. Added
centralized ID definitions and applied them to every entry detail button,
guided reflection control, settings toggle, paywall unlock button,
subscription/IAP button, lock screen control, and photo action dialog.
This commit is contained in:
Trey T
2026-03-26 07:59:52 -05:00
parent 8cc9400d65
commit e7648ddd8a
13 changed files with 131 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Shared/Views/NoteEditorView.swift
View File

@@ -81,6 +81,7 @@ struct NoteEditorView: View {
Button("Done") {
isTextFieldFocused = false
}
.accessibilityIdentifier(AccessibilityID.NoteEditor.keyboardDoneButton)
}
}
.onAppear {
@@ -226,7 +227,9 @@ struct EntryDetailView: View {
onDelete()
dismiss()
}
.accessibilityIdentifier(AccessibilityID.EntryDetail.deleteConfirmButton)
Button("Cancel", role: .cancel) { }
.accessibilityIdentifier(AccessibilityID.EntryDetail.deleteCancelButton)
} message: {
Text("Are you sure you want to delete this mood entry? This cannot be undone.")
}
@@ -461,6 +464,7 @@ struct EntryDetailView: View {
.font(.subheadline)
.fontWeight(.medium)
}
.accessibilityIdentifier(AccessibilityID.EntryDetail.reflectionBeginButton)
}
Button {
@@ -507,6 +511,7 @@ struct EntryDetailView: View {
)
}
.buttonStyle(.plain)
.accessibilityIdentifier(AccessibilityID.EntryDetail.reflectionCard)
}
}
@@ -526,6 +531,7 @@ struct EntryDetailView: View {
.font(.subheadline)
.fontWeight(.medium)
}
.accessibilityIdentifier(AccessibilityID.EntryDetail.photoButton)
}
.zIndex(1)
@@ -542,6 +548,7 @@ struct EntryDetailView: View {
.onTapGesture {
showFullScreenPhoto = true
}
.accessibilityIdentifier(AccessibilityID.EntryDetail.photoImage)
} else {
Button {
showPhotoOptions = true
@@ -568,22 +575,27 @@ struct EntryDetailView: View {
)
}
.buttonStyle(.plain)
.accessibilityIdentifier(AccessibilityID.EntryDetail.photoPlaceholder)
}
}
.confirmationDialog("Photo", isPresented: $showPhotoOptions, titleVisibility: .visible) {
Button("Take Photo") {
showCamera = true
}
.accessibilityIdentifier(AccessibilityID.EntryDetail.photoTakeButton)
Button("Choose from Library") {
showPhotoPicker = true
}
.accessibilityIdentifier(AccessibilityID.EntryDetail.photoChooseButton)
if let photoID = entry.photoID {
Button("Remove Photo", role: .destructive) {
_ = PhotoManager.shared.deletePhoto(id: photoID)
_ = DataController.shared.updatePhoto(forDate: entry.forDate, photoID: nil)
}
.accessibilityIdentifier(AccessibilityID.EntryDetail.photoRemoveButton)
}
Button("Cancel", role: .cancel) { }
.accessibilityIdentifier(AccessibilityID.EntryDetail.photoCancelButton)
}
}
@@ -634,9 +646,11 @@ struct FullScreenPhotoView: View {
.foregroundStyle(.white.opacity(0.8))
.padding()
}
.accessibilityIdentifier(AccessibilityID.FullScreenPhoto.closeButton)
}
.onTapGesture {
dismiss()
}
.accessibilityIdentifier(AccessibilityID.FullScreenPhoto.dismissArea)
}
}