Rewrite all UI tests following fail-fast TEST_RULES patterns

Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method

Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView

Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
  waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules

Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Tests iOS/TrialBannerTests.swift

@@ -13,48 +13,35 @@ import XCTest
 final class TrialBannerTests: BaseUITestCase {
     override var seedFixture: String? { "single_mood" }
 
-    /// TC-076: On fresh install, Settings shows an upgrade banner (indicating trial is active).
+    /// TC-076: On fresh install without bypass, Settings shows an upgrade banner.
     func testFreshInstall_ShowsTrialBanner() {
-        let tabBar = TabBarScreen(app: app)
-        let settingsScreen = tabBar.tapSettings()
-        settingsScreen.assertVisible()
-
-        // With default settings (bypassSubscription = true), the banner is hidden.
-        // Re-launch without bypass to see the banner.
+        // Re-launch without bypass to see the banner
         relaunchApp(resetState: true, bypassSubscription: false)
 
-        // Navigate to Settings
-        let freshTabBar = TabBarScreen(app: app)
-        let freshSettings = freshTabBar.tapSettings()
-        freshSettings.assertVisible()
+        let settingsScreen = TabBarScreen(app: app).tapSettings()
+        settingsScreen.assertVisible()
 
-        // Upgrade banner should be visible (trial is active, not bypassed)
-        let upgradeBanner = freshSettings.upgradeBanner
-        let bannerVisible = upgradeBanner.waitForExistence(timeout: 5)
+        settingsScreen.upgradeBanner
+            .waitForExistenceOrFail(
+                timeout: navigationTimeout,
+                message: "Upgrade banner should be visible on fresh install (trial active, no bypass)"
+            )
 
         captureScreenshot(name: "trial_banner_visible")
-
-        XCTAssertTrue(
-            bannerVisible,
-            "Upgrade banner should be visible on fresh install (trial active, no bypass)"
-        )
     }
 
     /// TC-080: With --bypass-subscription, the trial banner is hidden.
     func testTrialBanner_HiddenWithBypass() {
-        // Default BaseUITestCase has bypassSubscription = true
-        let tabBar = TabBarScreen(app: app)
-        let settingsScreen = tabBar.tapSettings()
+        let settingsScreen = TabBarScreen(app: app).tapSettings()
         settingsScreen.assertVisible()
 
-        // Upgrade banner should NOT be visible
         settingsScreen.assertUpgradeBannerHidden()
 
         captureScreenshot(name: "trial_banner_hidden_bypass")
     }
 }
 
-/// Separate test class for trial warning banner (TC-033) using expired trial state.
+/// Separate test class for trial warning banner (TC-033) using non-bypassed state.
 final class TrialWarningBannerTests: BaseUITestCase {
     override var seedFixture: String? { "single_mood" }
     override var bypassSubscription: Bool { false }
@@ -62,19 +49,15 @@ final class TrialWarningBannerTests: BaseUITestCase {
 
     /// TC-033: When trial is active (not expired, not bypassed), Settings shows a warning banner.
     func testTrialWarningBanner_Shown() {
-        let tabBar = TabBarScreen(app: app)
-        let settingsScreen = tabBar.tapSettings()
+        let settingsScreen = TabBarScreen(app: app).tapSettings()
         settingsScreen.assertVisible()
 
-        // The upgrade banner should be visible
-        let upgradeBanner = settingsScreen.upgradeBanner
-        let visible = upgradeBanner.waitForExistence(timeout: 5)
+        settingsScreen.upgradeBanner
+            .waitForExistenceOrFail(
+                timeout: navigationTimeout,
+                message: "Trial warning banner should be visible when trial is active and subscription not bypassed"
+            )
 
         captureScreenshot(name: "trial_warning_banner")
-
-        XCTAssertTrue(
-            visible,
-            "Trial warning banner should be visible when trial is active and subscription not bypassed"
-        )
     }
 }