admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rewrite all UI tests following fail-fast TEST_RULES patterns

Browse Source 
Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method

Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView

Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
  waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules

Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-24 17:00:30 -05:00
parent 2ef1c1ec51
commit d97db4910e
70 changed files with 1609 additions and 1874 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
Tests iOS/Screens/TabBarScreen.swift
View File

@@ -10,74 +10,53 @@ import XCTest
struct TabBarScreen {
let app: XCUIApplication
// MARK: - Tab Buttons
var dayTab: XCUIElement { tab(identifier: UITestID.Tab.day, labels: ["Day", "Main"]) }
var monthTab: XCUIElement { tab(identifier: UITestID.Tab.month, labels: ["Month"]) }
var yearTab: XCUIElement { tab(identifier: UITestID.Tab.year, labels: ["Year", "Filter"]) }
var insightsTab: XCUIElement { tab(identifier: UITestID.Tab.insights, labels: ["Insights"]) }
var settingsTab: XCUIElement { tab(identifier: UITestID.Tab.settings, labels: ["Settings"]) }
private let defaultTimeout: TimeInterval = 2
private let navigationTimeout: TimeInterval = 5
// MARK: - Actions
@discardableResult
func tapDay() -> DayScreen {
app.tapTab(identifier: UITestID.Tab.day, labels: ["Day", "Main"])
func tapDay(file: StaticString = #filePath, line: UInt = #line) -> DayScreen {
app.tapTab(identifier: UITestID.Tab.day, labels: ["Day", "Main"], timeout: navigationTimeout, file: file, line: line)
return DayScreen(app: app)
}
@discardableResult
func tapMonth() -> TabBarScreen {
app.tapTab(identifier: UITestID.Tab.month, labels: ["Month"])
func tapMonth(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
app.tapTab(identifier: UITestID.Tab.month, labels: ["Month"], timeout: navigationTimeout, file: file, line: line)
return self
}
@discardableResult
func tapYear() -> TabBarScreen {
app.tapTab(identifier: UITestID.Tab.year, labels: ["Year", "Filter"])
func tapYear(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
app.tapTab(identifier: UITestID.Tab.year, labels: ["Year", "Filter"], timeout: navigationTimeout, file: file, line: line)
return self
}
@discardableResult
func tapInsights() -> TabBarScreen {
app.tapTab(identifier: UITestID.Tab.insights, labels: ["Insights"])
func tapInsights(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
app.tapTab(identifier: UITestID.Tab.insights, labels: ["Insights"], timeout: navigationTimeout, file: file, line: line)
return self
}
@discardableResult
func tapSettings() -> SettingsScreen {
app.tapTab(identifier: UITestID.Tab.settings, labels: ["Settings"])
func tapSettings(file: StaticString = #filePath, line: UInt = #line) -> SettingsScreen {
app.tapTab(identifier: UITestID.Tab.settings, labels: ["Settings"], timeout: navigationTimeout, file: file, line: line)
return SettingsScreen(app: app)
}
// MARK: - Assertions
func assertDayTabSelected() {
XCTAssertTrue(dayTab.isSelected, "Day tab should be selected")
@discardableResult
func assertVisible(file: StaticString = #filePath, line: UInt = #line) -> TabBarScreen {
app.tabBars.firstMatch
.waitForExistenceOrFail(timeout: navigationTimeout, message: "Tab bar should be visible", file: file, line: line)
return self
}
func assertTabBarVisible() {
let visible = dayTab.waitForExistence(timeout: 5) ||
monthTab.waitForExistence(timeout: 1) ||
settingsTab.waitForExistence(timeout: 1)
XCTAssertTrue(visible, "Tab bar should be visible")
}
// MARK: - Element Resolution
private func tab(identifier: String, labels: [String]) -> XCUIElement {
let idMatch = app.tabBars.buttons[identifier]
if idMatch.exists {
return idMatch
}
for label in labels {
let match = app.tabBars.buttons[label]
if match.exists {
return match
}
}
return app.tabBars.buttons[labels.first ?? identifier]
func assertDayTabSelected(file: StaticString = #filePath, line: UInt = #line) {
let dayTab = app.tabBars.buttons[UITestID.Tab.day]
dayTab.waitForExistenceOrFail(timeout: defaultTimeout, message: "Day tab should exist", file: file, line: line)
XCTAssertTrue(dayTab.isSelected, "Day tab should be selected", file: file, line: line)
}
}