admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rewrite all UI tests following fail-fast TEST_RULES patterns

Browse Source 
Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method

Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView

Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
  waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules

Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-24 17:00:30 -05:00
parent 2ef1c1ec51
commit d97db4910e
70 changed files with 1609 additions and 1874 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
Tests iOS/PaywallGateTests.swift
View File

@@ -16,51 +16,39 @@ final class PaywallGateTests: BaseUITestCase {
/// TC-032: Paywall overlay appears on Month view when trial expired.
func testMonthView_PaywallOverlay_WhenTrialExpired() {
let tabBar = TabBarScreen(app: app)
tabBar.tapMonth()
TabBarScreen(app: app).tapMonth()
// Verify the paywall overlay is present
let overlay = app.descendants(matching: .any)
.matching(identifier: UITestID.Paywall.monthOverlay)
.firstMatch
XCTAssertTrue(
overlay.waitForExistence(timeout: 5),
"Month paywall overlay should appear when trial is expired"
)
app.element(UITestID.Paywall.monthOverlay)
.waitForExistenceOrFail(
timeout: navigationTimeout,
message: "Month paywall overlay should appear when trial is expired"
)
captureScreenshot(name: "month_paywall_overlay")
}
/// TC-039: Paywall overlay appears on Year view when trial expired.
func testYearView_PaywallOverlay_WhenTrialExpired() {
let tabBar = TabBarScreen(app: app)
tabBar.tapYear()
TabBarScreen(app: app).tapYear()
// Verify the paywall overlay is present
let overlay = app.descendants(matching: .any)
.matching(identifier: UITestID.Paywall.yearOverlay)
.firstMatch
XCTAssertTrue(
overlay.waitForExistence(timeout: 5),
"Year paywall overlay should appear when trial is expired"
)
app.element(UITestID.Paywall.yearOverlay)
.waitForExistenceOrFail(
timeout: navigationTimeout,
message: "Year paywall overlay should appear when trial is expired"
)
captureScreenshot(name: "year_paywall_overlay")
}
/// TC-048: Paywall overlay appears on Insights view when trial expired.
func testInsightsView_PaywallOverlay_WhenTrialExpired() {
let tabBar = TabBarScreen(app: app)
tabBar.tapInsights()
TabBarScreen(app: app).tapInsights()
// Verify the paywall overlay is present
let overlay = app.descendants(matching: .any)
.matching(identifier: UITestID.Paywall.insightsOverlay)
.firstMatch
XCTAssertTrue(
overlay.waitForExistence(timeout: 5),
"Insights paywall overlay should appear when trial is expired"
)
app.element(UITestID.Paywall.insightsOverlay)
.waitForExistenceOrFail(
timeout: navigationTimeout,
message: "Insights paywall overlay should appear when trial is expired"
)
captureScreenshot(name: "insights_paywall_overlay")
}