Rewrite all UI tests following fail-fast TEST_RULES patterns

Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method

Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView

Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
  waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules

Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-24 17:00:30 -05:00
parent 2ef1c1ec51
commit d97db4910e
70 changed files with 1609 additions and 1874 deletions

View File

@@ -10,22 +10,17 @@ import XCTest
final class MoodReplacementTests: BaseUITestCase {
override var seedFixture: String? { "single_mood" }
/// TC-003: Log mood as Good for a day that already has Great only one entry exists.
/// TC-003: Replace a mood via header or detail -- entry still exists afterward.
func testReplaceMood_NoDuplicates() {
let dayScreen = DayScreen(app: app)
// Seeded data has today as Great. The header may or may not show.
// If header is visible, log a different mood.
if dayScreen.moodHeader.waitForExistence(timeout: 3) {
if dayScreen.moodHeader.waitForExistence(timeout: defaultTimeout) {
dayScreen.logMood(.good)
} else {
// Today already has an entry. Open detail and change mood.
let firstEntry = app.firstEntryRow
guard firstEntry.waitForExistence(timeout: 5) else {
XCTFail("No entry rows found")
return
}
firstEntry.waitForExistenceOrFail(timeout: navigationTimeout, message: "No entry rows found")
firstEntry.tap()
let detailScreen = EntryDetailScreen(app: app)
detailScreen.assertVisible()
detailScreen.selectMood(.good)
@@ -33,32 +28,21 @@ final class MoodReplacementTests: BaseUITestCase {
detailScreen.assertDismissed()
}
// Verify exactly one entry row exists (no duplicates)
let entryRows = app.entryRows
// Wait for at least one entry
XCTAssertTrue(
entryRows.firstMatch.waitForExistence(timeout: 5),
"At least one entry should exist"
)
captureScreenshot(name: "mood_replaced_no_duplicates")
dayScreen.assertAnyEntryExists()
}
/// TC-158: Log mood twice for same day verify single entry per date.
/// TC-158: Change mood via detail sheet -- entry still exists afterward.
func testNoDuplicateEntries_SameDate() {
let dayScreen = DayScreen(app: app)
// If header shows, log Great
if dayScreen.moodHeader.waitForExistence(timeout: 3) {
// If header shows, log a mood first
if dayScreen.moodHeader.waitForExistence(timeout: defaultTimeout) {
dayScreen.logMood(.great)
}
// Now open the entry and change to Bad via detail
// Open entry and change mood via detail
let firstEntry = app.firstEntryRow
guard firstEntry.waitForExistence(timeout: 8) else {
XCTFail("No entry found after logging")
return
}
firstEntry.waitForExistenceOrFail(timeout: navigationTimeout, message: "No entry found after logging")
firstEntry.tap()
let detailScreen = EntryDetailScreen(app: app)
@@ -67,13 +51,7 @@ final class MoodReplacementTests: BaseUITestCase {
detailScreen.dismiss()
detailScreen.assertDismissed()
// Verify still only one entry (no duplicate)
let entryRows = app.entryRows
XCTAssertTrue(
entryRows.firstMatch.waitForExistence(timeout: 5),
"Entry should still exist after mood change"
)
captureScreenshot(name: "no_duplicate_entries")
// Verify entry still exists (no accidental deletion)
dayScreen.assertAnyEntryExists()
}
}