admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rewrite all UI tests following fail-fast TEST_RULES patterns

Browse Source 
Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method

Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView

Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
  waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules

Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-24 17:00:30 -05:00
parent 2ef1c1ec51
commit d97db4910e
70 changed files with 1609 additions and 1874 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
Tests iOS/DeepLinkTests.swift
View File

@@ -14,60 +14,47 @@ final class DeepLinkTests: BaseUITestCase {
/// TC-126: Opening a malformed deep link does not crash the app.
func testDeepLink_MalformedURL_NoCrash() {
// Verify app launched and is on Day tab
let tabBar = TabBarScreen(app: app)
XCTAssertTrue(
tabBar.dayTab.waitForExistence(timeout: 5),
"App should launch to Day tab"
)
tabBar.assertVisible()
// Send a malformed deep link
let malformedURL = URL(string: "reflect://invalidpath")!
app.open(malformedURL)
app.open(URL(string: "reflect://invalidpath")!)
// App should still be running and responsive — verify Day tab still exists
XCTAssertTrue(
tabBar.dayTab.waitForExistence(timeout: 5),
"App should remain functional after malformed deep link"
)
// App should still be running and responsive -- tab bar visible
tabBar.assertVisible()
// Navigate to another tab to verify full responsiveness
tabBar.tapYear()
XCTAssertTrue(
tabBar.yearTab.waitForExistence(timeout: 3),
"App should be fully navigable after malformed deep link"
)
app.element(UITestID.Paywall.yearOverlay)
.waitForExistenceOrFail(
timeout: navigationTimeout,
message: "App should be fully navigable after malformed deep link"
)
captureScreenshot(name: "deeplink_malformed_no_crash")
}
/// TC-125: reflect://subscribe opens subscription view.
func testDeepLink_Subscribe_OpensPaywall() {
// Verify app launched
let tabBar = TabBarScreen(app: app)
XCTAssertTrue(
tabBar.dayTab.waitForExistence(timeout: 5),
"App should launch to Day tab"
)
tabBar.assertVisible()
captureScreenshot(name: "deeplink_before_subscribe")
// Send subscribe deep link
let subscribeURL = URL(string: "reflect://subscribe")!
app.open(subscribeURL)
app.open(URL(string: "reflect://subscribe")!)
// Subscription view should appear as a sheet.
// Detect the SubscriptionStoreView container (works even when products are unavailable in test).
// Detect the SubscriptionStoreView container.
let storeContainer = app.descendants(matching: .any)
.matching(identifier: "Subscription Store View Container")
.firstMatch
let found = storeContainer.waitForExistence(timeout: 8)
storeContainer.waitForExistenceOrFail(
timeout: 8,
message: "Subscription view should appear after reflect://subscribe deep link"
)
captureScreenshot(name: "deeplink_subscribe_result")
XCTAssertTrue(found,
"Subscription view should appear after reflect://subscribe deep link"
)
}
}