admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rewrite all UI tests following fail-fast TEST_RULES patterns

Browse Source 
Rewrote 60+ test files to follow honeydue-style test guidelines:
- defaultTimeout=2s, navigationTimeout=5s — fail fast, no long waits
- No coordinate taps (except onboarding paged TabView swipes)
- No sleep(), no retry loops
- No guard...else { return } silent passes — XCTFail everywhere
- All elements by accessibility ID via UITestID constants
- Screen objects for all navigation/actions/assertions
- One logical assertion per test method

Added missing accessibility identifiers to app views:
- MonthView.swift: added AccessibilityID.MonthView.grid to ScrollView
- YearView.swift: added AccessibilityID.YearView.heatmap to ScrollView

Framework rewrites:
- BaseUITestCase: added session ID, localeArguments, extraLaunchArguments
- WaitHelpers: waitForExistenceOrFail, waitUntilHittableOrFail,
  waitForNonExistence, scrollIntoView, forceTap
- All 7 screen objects rewritten with fail-fast semantics
- TEST_RULES.md added with non-negotiable rules

Known remaining issues:
- OnboardingTests: paged TabView swipes unreliable on iOS 26 simulator
- SettingsLegalLinksTests: EULA/Privacy buttons too deep in DEBUG scroll
- Customization horizontal picker scrolling needs further tuning

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trey T
2026-03-24 17:00:30 -05:00
parent 2ef1c1ec51
commit d97db4910e
70 changed files with 1609 additions and 1874 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
Tests iOS/DayViewGroupingTests.swift
View File

@@ -12,38 +12,24 @@ final class DayViewGroupingTests: BaseUITestCase {
/// TC-019: Entries are grouped by year/month section headers.
func testEntries_GroupedBySectionHeaders() {
// 1. Wait for entry list to load with seeded data
let firstEntry = app.firstEntryRow
XCTAssertTrue(
firstEntry.waitForExistence(timeout: 5),
"Entry rows should exist with week_of_moods fixture"
// Wait for entry list to load with seeded data
app.firstEntryRow.waitForExistenceOrFail(
timeout: navigationTimeout,
message: "Entry rows should exist with week_of_moods fixture"
)
// 2. Verify at least one section header exists
let anySectionHeader = app.descendants(matching: .any)
.matching(NSPredicate(format: "identifier BEGINSWITH %@", UITestID.Day.sectionPrefix))
.firstMatch
XCTAssertTrue(
anySectionHeader.waitForExistence(timeout: 5),
"At least one day_section_ header should exist"
)
// 3. The week_of_moods fixture contains entries in the current month.
// Verify the section header for the current month/year exists.
// The week_of_moods fixture contains entries in the current month.
// Verify the section header for the current month/year exists.
let now = Date()
let calendar = Calendar.current
let month = calendar.component(.month, from: now)
let year = calendar.component(.year, from: now)
let expectedHeaderID = "day_section_\(month)_\(year)"
let currentMonthHeader = app.descendants(matching: .any)
.matching(identifier: expectedHeaderID)
.firstMatch
XCTAssertTrue(
currentMonthHeader.waitForExistence(timeout: 5),
"Section header '\(expectedHeaderID)' should exist for current month"
let currentMonthHeader = app.element(expectedHeaderID)
currentMonthHeader.waitForExistenceOrFail(
timeout: navigationTimeout,
message: "Section header '\(expectedHeaderID)' should exist for current month"
)
captureScreenshot(name: "day_view_section_headers")
}
}