admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix remaining 12 UI test failures: subscription state, hittability, tab selection

Browse Source 
- IAPManager: add resetForTesting() to discard stale cached subscription state
- UITestMode: call resetForTesting() after clearing defaults (fixes 5 banner tests)
- StabilityTests: use NSPredicate wait for isSelected (iOS 26 Liquid Glass)
- SettingsActionTests: use coordinate tap for clear data and analytics toggle
- IconPackTests: add horizontal scroll fallback for off-screen icon packs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-02-17 17:43:28 -06:00
parent 31dfd9cc68
commit c286294cd3
5 changed files with 35 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Tests iOS/StabilityTests.swift
View File

@@ -15,7 +15,7 @@ final class StabilityTests: BaseUITestCase {
let tabBar = TabBarScreen(app: app)
// 1. Day tab (default) - verify loaded
XCTAssertTrue(tabBar.dayTab.isSelected, "Should start on Day tab")
assertTabSelected(tabBar.dayTab, name: "Day (initial)")
captureScreenshot(name: "stability_day")
// 2. Open entry detail
@@ -34,22 +34,22 @@ final class StabilityTests: BaseUITestCase {
// 3. Month tab
tabBar.tapMonth()
XCTAssertTrue(tabBar.monthTab.isSelected, "Month tab should be selected")
assertTabSelected(tabBar.monthTab, name: "Month")
captureScreenshot(name: "stability_month")
// 4. Year tab
tabBar.tapYear()
XCTAssertTrue(tabBar.yearTab.isSelected, "Year tab should be selected")
assertTabSelected(tabBar.yearTab, name: "Year")
captureScreenshot(name: "stability_year")
// 5. Insights tab
tabBar.tapInsights()
XCTAssertTrue(tabBar.insightsTab.isSelected, "Insights tab should be selected")
assertTabSelected(tabBar.insightsTab, name: "Insights")
captureScreenshot(name: "stability_insights")
// 6. Settings tab - Customize sub-tab
tabBar.tapSettings()
XCTAssertTrue(tabBar.settingsTab.isSelected, "Settings tab should be selected")
assertTabSelected(tabBar.settingsTab, name: "Settings")
captureScreenshot(name: "stability_settings_customize")
// 7. Settings tab - Settings sub-tab
@@ -63,8 +63,16 @@ final class StabilityTests: BaseUITestCase {
// 9. Back to Day
tabBar.tapDay()
XCTAssertTrue(tabBar.dayTab.isSelected, "Day tab should be selected")
assertTabSelected(tabBar.dayTab, name: "Day")
captureScreenshot(name: "stability_full_navigation_complete")
}
/// Wait for a tab to become selected (iOS 26 Liquid Glass may delay state updates).
private func assertTabSelected(_ tab: XCUIElement, name: String, timeout: TimeInterval = 3) {
let predicate = NSPredicate(format: "isSelected == true")
let expectation = XCTNSPredicateExpectation(predicate: predicate, object: tab)
let result = XCTWaiter.wait(for: [expectation], timeout: timeout)
XCTAssertEqual(result, .completed, "\(name) tab should be selected")
}
}