admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix UI tests: remove tab content accessibility identifiers that override child identifiers

Browse Source 
The .accessibilityIdentifier() on TabView tab content propagated to ALL child views
in the accessibility tree, overriding identifiers like mood_header and settings_header.
Tab buttons are already accessible via labels (Day, Month, etc.) so these aren't needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-02-17 15:42:23 -06:00
parent 315fe968d4
commit 79a16fb476
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Shared/Views/MainTabView.swift
View File

@@ -28,31 +28,26 @@ struct MainTabView: View {
.tabItem { .tabItem {
Label(String(localized: "content_view_tab_main"), systemImage: "list.dash") Label(String(localized: "content_view_tab_main"), systemImage: "list.dash")
} }
.accessibilityIdentifier(AccessibilityID.Tab.day)
monthView monthView
.tabItem { .tabItem {
Label(String(localized: "content_view_tab_month"), systemImage: "calendar") Label(String(localized: "content_view_tab_month"), systemImage: "calendar")
} }
.accessibilityIdentifier(AccessibilityID.Tab.month)
yearView yearView
.tabItem { .tabItem {
Label(String(localized: "content_view_tab_filter"), systemImage: "line.3.horizontal.decrease.circle") Label(String(localized: "content_view_tab_filter"), systemImage: "line.3.horizontal.decrease.circle")
} }
.accessibilityIdentifier(AccessibilityID.Tab.year)
insightsView insightsView
.tabItem { .tabItem {
Label(String(localized: "content_view_tab_insights"), systemImage: "lightbulb.fill") Label(String(localized: "content_view_tab_insights"), systemImage: "lightbulb.fill")
} }
.accessibilityIdentifier(AccessibilityID.Tab.insights)
SettingsTabView() SettingsTabView()
.tabItem { .tabItem {
Label("Settings", systemImage: "gear") Label("Settings", systemImage: "gear")
} }
.accessibilityIdentifier(AccessibilityID.Tab.settings)
} }
.accentColor(textColor) .accentColor(textColor)
.sheet(isPresented: $needsOnboarding, onDismiss: { }, content: { .sheet(isPresented: $needsOnboarding, onDismiss: { }, content: {