Fix location/weather error handling and complete localization

Add authorization pre-check and 15s timeout to LocationManager to
prevent hanging continuations. WeatherManager now skips retry queue
when location permission is denied. Settings weather toggle shows
alert directing users to Settings when location is denied. Fill
remaining 32 untranslated strings to reach 100% localization.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-03-11 17:37:28 -05:00
parent 07b03fc8a1
commit 78d09803c3
4 changed files with 15813 additions and 14382 deletions

View File

@@ -42,9 +42,49 @@ final class LocationManager: NSObject {
return last
}
// Pre-check authorization before requesting location
switch manager.authorizationStatus {
case .denied, .restricted:
throw LocationError.permissionDenied
case .notDetermined:
manager.requestWhenInUseAuthorization()
// Wait briefly for authorization response
try await Task.sleep(for: .seconds(1))
if manager.authorizationStatus == .denied || manager.authorizationStatus == .restricted {
throw LocationError.permissionDenied
}
default:
break
}
// Request location with a 15-second timeout
return try await withCheckedThrowingContinuation { continuation in
self.locationContinuation = continuation
self.manager.requestLocation()
// Schedule timeout safe because everything is @MainActor (no race)
Task { @MainActor in
try? await Task.sleep(for: .seconds(15))
guard self.locationContinuation != nil else { return }
self.locationContinuation?.resume(throwing: LocationError.timeout)
self.locationContinuation = nil
}
}
}
}
// MARK: - Errors
enum LocationError: LocalizedError {
case permissionDenied
case timeout
var errorDescription: String? {
switch self {
case .permissionDenied:
return "Location permission denied"
case .timeout:
return "Location request timed out"
}
}
}