admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add 5 passing UI tests (batches 1-2) and mark 4 blocked tests RED

Browse Source 
Batch 1: TC-035 (donut chart), TC-036 (bar chart) — Year View stats
Batch 2: TC-037 (collapse/expand), TC-065 (privacy link), TC-066 (EULA link)
Blocked: TC-124, TC-068 (Settings ScrollView tap issue), TC-038 (share sheet)

New accessibility IDs: bypass subscription toggle, EULA, privacy policy buttons.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-02-20 10:02:17 -06:00
parent 5895b387be
commit 599e54aa72
9 changed files with 162 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
Tests iOS/YearViewDisplayTests.swift
View File

@@ -2,7 +2,7 @@
// YearViewDisplayTests.swift
// Tests iOS
//
// Year View display tests: donut chart, bar chart.
// Year View display tests: stats section with donut chart and bar chart.
// TC-035, TC-036
//
@@ -13,24 +13,29 @@ final class YearViewDisplayTests: BaseUITestCase {
override var bypassSubscription: Bool { true }
/// TC-035: Year View shows donut chart with mood distribution.
/// The donut chart center displays the entry count with "days" text.
func testYearView_DonutChartVisible() {
let tabBar = TabBarScreen(app: app)
tabBar.tapYear()
// Wait for Year tab to be selected and content to load
XCTAssertTrue(tabBar.yearTab.isSelected, "Year tab should be selected")
captureScreenshot(name: "year_view_loaded")
// Wait for stats section to render
let statsSection = app.element(UITestID.Year.statsSection)
XCTAssertTrue(
statsSection.waitForExistence(timeout: 8),
"Year stats section should be visible"
)
// The donut chart is inside the stats section of the first YearCard.
// Try finding by accessibility identifier first, then fall back to presence of "days" text.
let donutChart = app.element(UITestID.Year.donutChart)
let found = donutChart.waitForExistence(timeout: 8) ||
app.swipeUntilExists(donutChart, direction: .up, maxSwipes: 3, timeoutPerTry: 1.0)
// The donut chart center shows "days" — search globally since
// SwiftUI flattens the accessibility tree under GeometryReader.
let daysLabel = app.staticTexts["days"]
XCTAssertTrue(
daysLabel.waitForExistence(timeout: 3),
"Donut chart should display 'days' label in center"
)
captureScreenshot(name: "year_donut_chart")
XCTAssertTrue(found, "Donut chart should be visible in Year View")
}
/// TC-036: Year View shows bar chart with mood percentages.
@@ -40,12 +45,23 @@ final class YearViewDisplayTests: BaseUITestCase {
XCTAssertTrue(tabBar.yearTab.isSelected, "Year tab should be selected")
let barChart = app.element(UITestID.Year.barChart)
let found = barChart.waitForExistence(timeout: 8) ||
app.swipeUntilExists(barChart, direction: .up, maxSwipes: 3, timeoutPerTry: 1.0)
let statsSection = app.element(UITestID.Year.statsSection)
XCTAssertTrue(
statsSection.waitForExistence(timeout: 8),
"Year stats section should be visible"
)
// week_of_moods fixture: 2 great, 2 good, 1 avg, 1 bad, 1 horrible
// Expected percentages: 28% (great, good) and 14% (avg, bad, horrible).
// Search for any of the expected percentage labels.
let found28 = app.staticTexts["28%"].waitForExistence(timeout: 3)
let found14 = app.staticTexts["14%"].waitForExistence(timeout: 2)
captureScreenshot(name: "year_bar_chart")
XCTAssertTrue(found, "Bar chart should be visible in Year View")
XCTAssertTrue(
found28 || found14,
"Bar chart should show at least one percentage value (28% or 14%)"
)
}
}