Stabilize iOS UI test foundation and fix flaky suites

Shared/Onboarding/views/OnboardingDay.swift

@@ -169,6 +169,7 @@ struct DayOptionCard: View {
             )
         }
         .buttonStyle(.plain)
+        .accessibilityElement(children: .combine)
         .accessibilityLabel("\(title), \(subtitle)")
         .accessibilityHint(example)
         .accessibilityAddTraits(isSelected ? [.isSelected] : [])

Shared/Onboarding/views/OnboardingStyle.swift

@@ -91,6 +91,7 @@ struct OnboardingStyle: View {
             // Apply default theme on appear
             selectedTheme.apply()
         }
+        .accessibilityIdentifier(AccessibilityID.Onboarding.styleScreen)
     }
 }
 

Shared/Onboarding/views/OnboardingSubscription.swift

@@ -115,9 +115,9 @@ struct OnboardingSubscription: View {
                                 .shadow(color: .black.opacity(0.15), radius: 10, y: 5)
                         )
                     }
+                    .accessibilityIdentifier(AccessibilityID.Onboarding.subscribeButton)
                     .accessibilityLabel(String(localized: "Get Personal Insights"))
                     .accessibilityHint(String(localized: "Opens subscription options"))
-                    .accessibilityIdentifier(AccessibilityID.Onboarding.subscribeButton)
 
                     // Skip button
                     Button(action: {
@@ -128,10 +128,11 @@ struct OnboardingSubscription: View {
                         Text("Maybe Later")
                             .font(.body.weight(.medium))
                             .foregroundColor(.white.opacity(0.8))
+                            .accessibilityIdentifier(AccessibilityID.Onboarding.skipButton)
                     }
+                    .accessibilityIdentifier(AccessibilityID.Onboarding.skipButton)
                     .accessibilityLabel(String(localized: "Maybe Later"))
                     .accessibilityHint(String(localized: "Skip subscription and complete setup"))
-                    .accessibilityIdentifier(AccessibilityID.Onboarding.skipButton)
                     .padding(.top, 4)
                 }
                 .padding(.horizontal, 24)

Shared/Onboarding/views/OnboardingTime.swift

@@ -93,6 +93,7 @@ struct OnboardingTime: View {
                 .accessibilityElement(children: .combine)
             }
         }
+        .accessibilityIdentifier(AccessibilityID.Onboarding.timeScreen)
     }
 }