admin/Reflect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix production crash points, actor-isolation warnings, and rebrand URLs

Browse Source 
Remove all fatalError/force unwrap/force cast crash points from production
paths (ShowBasedOnVoteLogics, Random, ReflectApp, NoteEditorView). Fix
actor-isolation warnings by wrapping off-main-thread AnalyticsManager calls
in Task { @MainActor in } (LocalNotification) and replacing DispatchQueue
with Task.detached + MainActor.run (LiveActivityPreviewView). Update legal
URLs from feels.88oakapps.com to reflect.88oakapps.com in SettingsView.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-02-26 19:31:10 -06:00
parent 16c5c34942
commit 3a4e60587a
8 changed files with 43 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Shared/Views/NoteEditorView.swift
View File

@@ -478,9 +478,9 @@ struct EntryDetailView: View {
Button("Choose from Library") {
showPhotoPicker = true
}
if entry.photoID != nil {
if let photoID = entry.photoID {
Button("Remove Photo", role: .destructive) {
_ = PhotoManager.shared.deletePhoto(id: entry.photoID!)
_ = PhotoManager.shared.deletePhoto(id: photoID)
_ = DataController.shared.updatePhoto(forDate: entry.forDate, photoID: nil)
}
}

17
Shared/Views/SettingsView/LiveActivityPreviewView.swift
View File

@@ -321,9 +321,12 @@ struct LiveActivityRecordingView: View {
exportPath = outputDir.path
print("📁 Exporting frames to: \(exportPath)")
// Export frames on background queue
DispatchQueue.global(qos: .userInitiated).async {
for streak in 1...targetStreak {
let target = targetStreak
let outDir = outputDir
let outPath = exportPath
Task.detached(priority: .userInitiated) {
for streak in 1...target {
let mood = getMoodForStreak(streak)
let cardView = LiveActivityCardView(
@@ -337,21 +340,21 @@ struct LiveActivityRecordingView: View {
if let uiImage = renderer.uiImage {
let filename = String(format: "frame_%04d.png", streak)
let fileURL = outputDir.appendingPathComponent(filename)
let fileURL = outDir.appendingPathComponent(filename)
if let pngData = uiImage.pngData() {
try? pngData.write(to: fileURL)
}
}
DispatchQueue.main.async {
await MainActor.run {
exportProgress = streak
}
}
DispatchQueue.main.async {
await MainActor.run {
exportComplete = true
print("✅ Export complete! \(targetStreak) frames saved to: \(exportPath)")
print("✅ Export complete! \(target) frames saved to: \(outPath)")
}
}
}

8
Shared/Views/SettingsView/SettingsView.swift
View File

@@ -1030,7 +1030,7 @@ struct SettingsContentView: View {
private var eulaButton: some View {
Button(action: {
AnalyticsManager.shared.track(.eulaViewed)
if let url = URL(string: "https://feels.88oakapps.com/eula.html") {
if let url = URL(string: "https://reflect.88oakapps.com/eula.html") {
UIApplication.shared.open(url)
}
}, label: {
@@ -1049,7 +1049,7 @@ struct SettingsContentView: View {
private var privacyButton: some View {
Button(action: {
AnalyticsManager.shared.track(.privacyPolicyViewed)
if let url = URL(string: "https://feels.88oakapps.com/privacy.html") {
if let url = URL(string: "https://reflect.88oakapps.com/privacy.html") {
UIApplication.shared.open(url)
}
}, label: {
@@ -1757,7 +1757,7 @@ struct SettingsView: View {
private var eulaButton: some View {
Button(action: {
AnalyticsManager.shared.track(.eulaViewed)
openURL(URL(string: "https://feels.88oakapps.com/eula.html")!)
if let url = URL(string: "https://reflect.88oakapps.com/eula.html") { openURL(url) }
}, label: {
Text(String(localized: "settings_view_show_eula"))
.foregroundColor(textColor)
@@ -1772,7 +1772,7 @@ struct SettingsView: View {
private var privacyButton: some View {
Button(action: {
AnalyticsManager.shared.track(.privacyPolicyViewed)
openURL(URL(string: "https://feels.88oakapps.com/privacy.html")!)
if let url = URL(string: "https://reflect.88oakapps.com/privacy.html") { openURL(url) }
}, label: {
Text(String(localized: "settings_view_show_privacy"))
.foregroundColor(textColor)