Fix build errors, resolve all warnings, and improve code quality
Widget Extension Fixes: - Create standalone WidgetDataProvider for widget data isolation - Add WIDGET_EXTENSION compiler flag for conditional compilation - Fix DataController references in widget-shared files - Sync widget version numbers with main app (23, 1.0.2) - Add WidgetBackground color to asset catalog Warning Resolutions: - Fix UIScreen.main deprecation in BGView and SharingListView - Fix Text '+' concatenation deprecation in PurchaseButtonView and SettingsTabView - Fix exhaustive switch in BiometricAuthManager (add .none case) - Fix var to let in ExportService (3 instances) - Fix unused result warning in NoteEditorView - Fix ForEach duplicate ID warnings in MonthView and YearView Code Quality Improvements: - Wrap bypassSubscription in #if DEBUG for security - Rename StupidAssCustomWidgetObservableObject to CustomWidgetStateViewModel - Add @MainActor to IconViewModel - Replace fatalError with graceful fallback in SharedModelContainer - Add [weak self] to closures in DayViewViewModel - Add OSLog-based AppLogger for production logging - Add ImageCache with NSCache for memory efficiency - Add AccessibilityHelpers with Reduce Motion support - Create DataControllerProtocol for dependency injection - Update .gitignore with secrets exclusions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -13,7 +13,7 @@ struct MonthDetailView: View {
|
||||
@AppStorage(UserDefaultsStore.Keys.moodTint.rawValue, store: GroupUserDefaults.groupDefaults) private var moodTint: MoodTints = .Default
|
||||
@AppStorage(UserDefaultsStore.Keys.textColor.rawValue, store: GroupUserDefaults.groupDefaults) private var textColor: Color = DefaultTextColor.textColor
|
||||
|
||||
@StateObject private var shareImage = StupidAssShareObservableObject()
|
||||
@StateObject private var shareImage = ShareImageStateViewModel()
|
||||
|
||||
@State private var showingSheet = false
|
||||
@State private var selectedEntry: MoodEntryModel?
|
||||
@@ -58,8 +58,8 @@ struct MonthDetailView: View {
|
||||
impactMed.impactOccurred()
|
||||
|
||||
let _image = self.image
|
||||
self.shareImage.showFuckingSheet = true
|
||||
self.shareImage.fuckingWrappedShrable = _image
|
||||
self.shareImage.showSheet = true
|
||||
self.shareImage.selectedShareImage = _image
|
||||
}
|
||||
}
|
||||
.background(
|
||||
@@ -81,8 +81,8 @@ struct MonthDetailView: View {
|
||||
.background(
|
||||
theme.currentTheme.bg
|
||||
)
|
||||
.sheet(isPresented: self.$shareImage.showFuckingSheet) {
|
||||
if let uiImage = self.shareImage.fuckingWrappedShrable {
|
||||
.sheet(isPresented: self.$shareImage.showSheet) {
|
||||
if let uiImage = self.shareImage.selectedShareImage {
|
||||
ShareSheet(photo: uiImage)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -18,20 +18,20 @@ struct MonthView: View {
|
||||
|
||||
@AppStorage(UserDefaultsStore.Keys.shape.rawValue, store: GroupUserDefaults.groupDefaults) private var shape: BGShape = .circle
|
||||
|
||||
@StateObject private var shareImage = StupidAssShareObservableObject()
|
||||
@StateObject private var shareImage = ShareImageStateViewModel()
|
||||
|
||||
// store a value that gets changed when user updates custom colors to update the view since the moodTint doesn't change
|
||||
@AppStorage(UserDefaultsStore.Keys.customMoodTintUpdateNumber.rawValue, store: GroupUserDefaults.groupDefaults) private var customMoodTintUpdateNumber: Int = 0
|
||||
|
||||
@EnvironmentObject var iapManager: IAPManager
|
||||
@StateObject private var selectedDetail = StupidAssDetailViewObservableObject()
|
||||
@StateObject private var selectedDetail = DetailViewStateViewModel()
|
||||
@State private var showingSheet = false
|
||||
@StateObject private var onboardingData = OnboardingDataDataManager.shared
|
||||
@StateObject private var filteredDays = DaysFilterClass.shared
|
||||
|
||||
class StupidAssDetailViewObservableObject: ObservableObject {
|
||||
@Published var fuckingWrapped: MonthDetailView? = nil
|
||||
@Published var showFuckingSheet = false
|
||||
class DetailViewStateViewModel: ObservableObject {
|
||||
@Published var selectedItem: MonthDetailView? = nil
|
||||
@Published var showSheet = false
|
||||
}
|
||||
|
||||
// Heatmap-style grid with tight spacing
|
||||
@@ -70,12 +70,12 @@ struct MonthView: View {
|
||||
entries: entries,
|
||||
parentViewModel: viewModel
|
||||
)
|
||||
selectedDetail.fuckingWrapped = detailView
|
||||
selectedDetail.showFuckingSheet = true
|
||||
selectedDetail.selectedItem = detailView
|
||||
selectedDetail.showSheet = true
|
||||
},
|
||||
onShare: { image in
|
||||
shareImage.fuckingWrappedShrable = image
|
||||
shareImage.showFuckingSheet = true
|
||||
shareImage.selectedShareImage = image
|
||||
shareImage.showSheet = true
|
||||
}
|
||||
)
|
||||
}
|
||||
@@ -139,12 +139,12 @@ struct MonthView: View {
|
||||
theme.currentTheme.bg
|
||||
.edgesIgnoringSafeArea(.all)
|
||||
)
|
||||
.sheet(isPresented: $selectedDetail.showFuckingSheet,
|
||||
.sheet(isPresented: $selectedDetail.showSheet,
|
||||
onDismiss: didDismiss) {
|
||||
selectedDetail.fuckingWrapped
|
||||
selectedDetail.selectedItem
|
||||
}
|
||||
.sheet(isPresented: self.$shareImage.showFuckingSheet) {
|
||||
if let uiImage = self.shareImage.fuckingWrappedShrable {
|
||||
.sheet(isPresented: self.$shareImage.showSheet) {
|
||||
if let uiImage = self.shareImage.selectedShareImage {
|
||||
ImageOnlyShareSheet(photo: uiImage)
|
||||
}
|
||||
}
|
||||
@@ -157,8 +157,8 @@ struct MonthView: View {
|
||||
|
||||
|
||||
func didDismiss() {
|
||||
selectedDetail.showFuckingSheet = false
|
||||
selectedDetail.fuckingWrapped = nil
|
||||
selectedDetail.showSheet = false
|
||||
selectedDetail.selectedItem = nil
|
||||
}
|
||||
}
|
||||
|
||||
@@ -329,8 +329,8 @@ struct MonthCard: View {
|
||||
|
||||
// Weekday Labels
|
||||
HStack(spacing: 2) {
|
||||
ForEach(weekdayLabels, id: \.self) { day in
|
||||
Text(day)
|
||||
ForEach(weekdayLabels.indices, id: \.self) { index in
|
||||
Text(weekdayLabels[index])
|
||||
.font(.caption2.weight(.medium))
|
||||
.foregroundColor(textColor.opacity(0.5))
|
||||
.frame(maxWidth: .infinity)
|
||||
@@ -384,6 +384,26 @@ struct HeatmapCell: View {
|
||||
RoundedRectangle(cornerRadius: 4)
|
||||
.fill(cellColor)
|
||||
.aspectRatio(1, contentMode: .fit)
|
||||
.accessibilityLabel(accessibilityDescription)
|
||||
.accessibilityHint(entry.mood != .placeholder && entry.mood != .missing ? "Double tap to edit" : "")
|
||||
}
|
||||
|
||||
private var accessibilityDescription: String {
|
||||
if entry.mood == .placeholder {
|
||||
return "Empty day"
|
||||
} else if entry.mood == .missing {
|
||||
return "No mood logged for \(formattedDate)"
|
||||
} else if !isFiltered {
|
||||
return "\(formattedDate): \(entry.mood.strValue) (filtered out)"
|
||||
} else {
|
||||
return "\(formattedDate): \(entry.mood.strValue)"
|
||||
}
|
||||
}
|
||||
|
||||
private var formattedDate: String {
|
||||
let formatter = DateFormatter()
|
||||
formatter.dateStyle = .medium
|
||||
return formatter.string(from: entry.forDate)
|
||||
}
|
||||
|
||||
private var cellColor: Color {
|
||||
|
||||
Reference in New Issue
Block a user