Fix build errors, resolve all warnings, and improve code quality

Widget Extension Fixes:
- Create standalone WidgetDataProvider for widget data isolation
- Add WIDGET_EXTENSION compiler flag for conditional compilation
- Fix DataController references in widget-shared files
- Sync widget version numbers with main app (23, 1.0.2)
- Add WidgetBackground color to asset catalog

Warning Resolutions:
- Fix UIScreen.main deprecation in BGView and SharingListView
- Fix Text '+' concatenation deprecation in PurchaseButtonView and SettingsTabView
- Fix exhaustive switch in BiometricAuthManager (add .none case)
- Fix var to let in ExportService (3 instances)
- Fix unused result warning in NoteEditorView
- Fix ForEach duplicate ID warnings in MonthView and YearView

Code Quality Improvements:
- Wrap bypassSubscription in #if DEBUG for security
- Rename StupidAssCustomWidgetObservableObject to CustomWidgetStateViewModel
- Add @MainActor to IconViewModel
- Replace fatalError with graceful fallback in SharedModelContainer
- Add [weak self] to closures in DayViewViewModel
- Add OSLog-based AppLogger for production logging
- Add ImageCache with NSCache for memory efficiency
- Add AccessibilityHelpers with Reduce Motion support
- Create DataControllerProtocol for dependency injection
- Update .gitignore with secrets exclusions

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Trey t
2025-12-20 00:48:35 -06:00
parent 31a68b7102
commit 356ce9ea62
41 changed files with 1072 additions and 187 deletions

View File

@@ -9,6 +9,7 @@
import Foundation
import UIKit
import SwiftUI
import os.log
@MainActor
class PhotoManager: ObservableObject {
@@ -26,7 +27,7 @@ class PhotoManager: ObservableObject {
guard let containerURL = FileManager.default.containerURL(
forSecurityApplicationGroupIdentifier: Constants.currentGroupShareId
) else {
print("PhotoManager: Failed to get app group container")
AppLogger.photos.error("Failed to get app group container")
return nil
}
@@ -37,7 +38,7 @@ class PhotoManager: ObservableObject {
do {
try FileManager.default.createDirectory(at: photosURL, withIntermediateDirectories: true)
} catch {
print("PhotoManager: Failed to create photos directory: \(error)")
AppLogger.photos.error("Failed to create photos directory: \(error.localizedDescription)")
return nil
}
}
@@ -54,7 +55,7 @@ class PhotoManager: ObservableObject {
do {
try FileManager.default.createDirectory(at: thumbnailsURL, withIntermediateDirectories: true)
} catch {
print("PhotoManager: Failed to create thumbnails directory: \(error)")
AppLogger.photos.error("Failed to create thumbnails directory: \(error.localizedDescription)")
return nil
}
}
@@ -76,14 +77,14 @@ class PhotoManager: ObservableObject {
// Save full resolution
let fullURL = photosDir.appendingPathComponent(filename)
guard let fullData = image.jpegData(compressionQuality: compressionQuality) else {
print("PhotoManager: Failed to create JPEG data")
AppLogger.photos.error("Failed to create JPEG data")
return nil
}
do {
try fullData.write(to: fullURL)
} catch {
print("PhotoManager: Failed to save photo: \(error)")
AppLogger.photos.error("Failed to save photo: \(error.localizedDescription)")
return nil
}
@@ -151,7 +152,7 @@ class PhotoManager: ObservableObject {
do {
try FileManager.default.removeItem(at: fullURL)
} catch {
print("PhotoManager: Failed to delete photo: \(error)")
AppLogger.photos.error("Failed to delete photo: \(error.localizedDescription)")
success = false
}
}