Fix onboarding voting test for new Day→Time page order

The onboarding flow changed from Welcome→Time→Day to
Welcome→Day→Time. Updated test to swipe once instead of twice.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Tests iOS/OnboardingVotingTests.swift

@@ -21,8 +21,7 @@ final class OnboardingVotingTests: BaseUITestCase {
             "Onboarding welcome screen should appear"
         )
 
-        // Swipe exactly 2 times: Welcome → Time → Day
-        swipeToNext()
+        // Swipe once: Welcome → Day (Day is now page 2, before Time)
         swipeToNext()
 
         // Look for the "Which day should" title text to confirm we're on the day page
@@ -30,11 +29,6 @@ final class OnboardingVotingTests: BaseUITestCase {
             NSPredicate(format: "label CONTAINS[c] 'Which day'")
         ).firstMatch
 
-        // If not found, try one more swipe (may need 3 depending on animation)
-        if !dayTitle.waitForExistence(timeout: 3) {
-            swipeToNext()
-        }
-
         XCTAssertTrue(
             dayTitle.waitForExistence(timeout: 5),
             "Day screen title 'Which day should you rate?' should be visible"