Fix remaining 17 UI test failures: group defaults, identifiers, hittability, date format

- resetAppState: use correct suite name to clear group defaults (fixes stale subscription state)
- Reorder configureIfNeeded: set expireTrial before IAPManager init
- Add browse_themes_button identifier to CustomizeView Browse Themes button
- Add mood_button_* identifiers to Entry Detail mood grid in NoteEditorView
- Use coordinate-based tap throughout all test screens (iOS 26 Liquid Glass hittability)
- Fix HeaderMoodLogging date format: M/d/yyyy → yyyy/MM/dd to match entry_row identifiers
- AppLaunchTests: wait for isSelected state with NSPredicate instead of immediate check
- OnboardingTests: add waits between swipes and retry logic for skip button

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Trey t
2026-02-17 16:46:18 -06:00
parent 44b46f88e2
commit 224341fd98
13 changed files with 89 additions and 60 deletions

View File

@@ -31,22 +31,30 @@ final class AppLaunchTests: BaseUITestCase {
// Month tab
tabBar.tapMonth()
XCTAssertTrue(tabBar.monthTab.isSelected, "Month tab should be selected")
assertTabSelected(tabBar.monthTab, name: "Month")
// Year tab
tabBar.tapYear()
XCTAssertTrue(tabBar.yearTab.isSelected, "Year tab should be selected")
assertTabSelected(tabBar.yearTab, name: "Year")
// Insights tab
tabBar.tapInsights()
XCTAssertTrue(tabBar.insightsTab.isSelected, "Insights tab should be selected")
assertTabSelected(tabBar.insightsTab, name: "Insights")
// Settings tab
tabBar.tapSettings()
XCTAssertTrue(tabBar.settingsTab.isSelected, "Settings tab should be selected")
assertTabSelected(tabBar.settingsTab, name: "Settings")
// Back to Day
tabBar.tapDay()
XCTAssertTrue(tabBar.dayTab.isSelected, "Day tab should be selected")
assertTabSelected(tabBar.dayTab, name: "Day")
}
/// Wait for a tab to become selected (iOS 26 Liquid Glass may delay state updates).
private func assertTabSelected(_ tab: XCUIElement, name: String, timeout: TimeInterval = 3) {
let predicate = NSPredicate(format: "isSelected == true")
let expectation = XCTNSPredicateExpectation(predicate: predicate, object: tab)
let result = XCTWaiter.wait(for: [expectation], timeout: timeout)
XCTAssertEqual(result, .completed, "\(name) tab should be selected")
}
}